encoding/base32: handle NoPadding when using buffered encoding in Close

zegl · ianlancetaylor · commit 10529a01fd8b · 2018-05-09T22:10:32.000Z
This changes makes encoder.Close aware of how many bytes to write if there is any data left in the buffer. Fixes golang#25295 Change-Id: I4138891359935509cb561c453b8059ba2b9e576b GitHub-Last-Rev: f374096 GitHub-Pull-Request: golang#25316 Reviewed-on: https://go-review.googlesource.com/112515 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
diff --git a/src/encoding/base32/base32.go b/src/encoding/base32/base32.go
@@ -244,8 +244,9 @@ func (e *encoder) Close() error {
 	// If there's anything left in the buffer, flush it out
 	if e.err == nil && e.nbuf > 0 {
 		e.enc.Encode(e.out[0:], e.buf[0:e.nbuf])
+		encodedLen := e.enc.EncodedLen(e.nbuf)
 		e.nbuf = 0
-		_, e.err = e.w.Write(e.out[0:8])
+		_, e.err = e.w.Write(e.out[0:encodedLen])
 	}
 	return e.err
 }
diff --git a/src/encoding/base32/base32_test.go b/src/encoding/base32/base32_test.go
@@ -658,3 +658,31 @@ func TestEncodedDecodedLen(t *testing.T) {
 		})
 	}
 }
+
+func TestWithoutPaddingClose(t *testing.T) {
+	encodings := []*Encoding{
+		StdEncoding,
+		StdEncoding.WithPadding(NoPadding),
+	}
+
+	for _, encoding := range encodings {
+		for _, testpair := range pairs {
+
+			var buf bytes.Buffer
+			encoder := NewEncoder(encoding, &buf)
+			encoder.Write([]byte(testpair.decoded))
+			encoder.Close()
+
+			expected := testpair.encoded
+			if encoding.padChar == NoPadding {
+				expected = strings.Replace(expected, "=", "", -1)
+			}
+
+			res := buf.String()
+
+			if res != expected {
+				t.Errorf("Expected %s got %s; padChar=%d", expected, res, encoding.padChar)
+			}
+		}
+	}
+}

Original file line number	Diff line number	Diff line change
`@@ -244,8 +244,9 @@ func (e *encoder) Close() error {`
`244`	`244`	`// If there's anything left in the buffer, flush it out`
`245`	`245`	`if e.err == nil && e.nbuf > 0 {`
`246`	`246`	`e.enc.Encode(e.out[0:], e.buf[0:e.nbuf])`
	`247`	`+ encodedLen := e.enc.EncodedLen(e.nbuf)`
`247`	`248`	`e.nbuf = 0`
`248`		`- _, e.err = e.w.Write(e.out[0:8])`
	`249`	`+ _, e.err = e.w.Write(e.out[0:encodedLen])`
`249`	`250`	`}`
`250`	`251`	`return e.err`
`251`	`252`	`}`