net: remove obsolete TestLookupHost

cixtor · cixtor · commit 047f07a285ed · 2015-06-16T17:37:29.000Z
The motivation of TestLookupHost was to test codepaths on LookupHost, LookupIP when we set CGO_ENABLED=1. Now we have serveral tests on those APIs and their codepaths such as TestLookupGooglePublicDNSAddr, TestCgoLookupIP, TestGoLookupIP, and the test using the ambiguous source "localhost" is unnecessary. Fixes golang#11182. Change-Id: I397c823e1648114d91a229b316477bff2948b4f9 Reviewed-on: https://go-review.googlesource.com/11057 Reviewed-by: Ian Lance Taylor <iant@golang.org>
diff --git a/src/net/hosts_test.go b/src/net/hosts_test.go
@@ -6,7 +6,6 @@ package net
 
 import (
 	"reflect"
-	"sort"
 	"testing"
 )
 
@@ -119,17 +118,3 @@ func TestLookupStaticAddr(t *testing.T) {
 		}
 	}
 }
-
-func TestLookupHost(t *testing.T) {
-	// Can't depend on this to return anything in particular,
-	// but if it does return something, make sure it doesn't
-	// duplicate addresses (a common bug due to the way
-	// getaddrinfo works).
-	addrs, _ := LookupHost("localhost")
-	sort.Strings(addrs)
-	for i := 0; i+1 < len(addrs); i++ {
-		if addrs[i] == addrs[i+1] {
-			t.Fatalf("LookupHost(\"localhost\") = %v, has duplicate addresses", addrs)
-		}
-	}
-}

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,6 @@ package net`
`6`	`6`
`7`	`7`	`import (`
`8`	`8`	`"reflect"`
`9`		`- "sort"`
`10`	`9`	`"testing"`
`11`	`10`	`)`
`12`	`11`
`@@ -119,17 +118,3 @@ func TestLookupStaticAddr(t *testing.T) {`
`119`	`118`	`}`
`120`	`119`	`}`
`121`	`120`	`}`
`122`		`-`
`123`		`-func TestLookupHost(t *testing.T) {`
`124`		`- // Can't depend on this to return anything in particular,`
`125`		`- // but if it does return something, make sure it doesn't`
`126`		`- // duplicate addresses (a common bug due to the way`
`127`		`- // getaddrinfo works).`
`128`		`- addrs, _ := LookupHost("localhost")`
`129`		`- sort.Strings(addrs)`
`130`		`- for i := 0; i+1 < len(addrs); i++ {`
`131`		`- if addrs[i] == addrs[i+1] {`
`132`		`- t.Fatalf("LookupHost(\"localhost\") = %v, has duplicate addresses", addrs)`
`133`		`- }`
`134`		`- }`
`135`		`-}`