builtin-tag.c: remove cruft

g-pape · gitster · commit fd74cb087412 · 2008-02-22T07:02:40.000-08:00
After changing builtin-tag.c to use strbuf in fd17f5b (Replace all read_fd use with strbuf_read, and get rid of it.), the last condition in do_sign() will always be false, as it's checked already right above. So let's remove the cruft. Signed-off-by: Gerrit Pape <pape@smarden.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/builtin-tag.c b/builtin-tag.c
@@ -236,9 +236,6 @@ static int do_sign(struct strbuf *buffer)
 	if (finish_command(&gpg) || !len || len < 0)
 		return error("gpg failed to sign the tag");
 
-	if (len < 0)
-		return error("could not read the entire signature from gpg.");
-
 	return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -236,9 +236,6 @@ static int do_sign(struct strbuf *buffer)`
`236`	`236`	`if (finish_command(&gpg) \|\| !len \|\| len < 0)`
`237`	`237`	`return error("gpg failed to sign the tag");`
`238`	`238`
`239`		`- if (len < 0)`
`240`		`- return error("could not read the entire signature from gpg.");`
`241`		`-`
`242`	`239`	`return 0;`
`243`	`240`	`}`
`244`	`241`