t4018: drop "debugging" cat from hunk-header tests

peff · gitster · commit fbce03d3291e · 2020-01-16T14:46:28.000-08:00
We run a series of hunk-header tests in a loop, and each one does this:

  test_when_finished 'cat actual' &amp;&amp;      # for debugging only

This is pretty pointless. When the test succeeds, we waste time running
a useless cat process. If you're debugging a failure with "-i", then we
won't run the when-finished part at all. So it helps only if you're
running with something like "--verbose-log".

Since we expect the tests to succeed most of the time, a better way to
do this would be a helper that checks the output and dumps "actual" only
when it fails. But it's probably not even worth the effort, as anyone
debugging a failure could just run with "-i" and investigate the
"actual" file themselves.

Signed-off-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/t4018-diff-funcname.sh b/t/t4018-diff-funcname.sh
@@ -105,7 +105,6 @@ do
 		result=success
 	fi
 	test_expect_$result "hunk header: $i" "
-		test_when_finished 'cat actual' &&	# for debugging only
 		git diff -U1 $i >actual &&
 		grep '@@ .* @@.*RIGHT' actual
 	"

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,6 @@ do`
`105`	`105`	`result=success`
`106`	`106`	`fi`
`107`	`107`	`test_expect_$result "hunk header: $i" "`
`108`		`- test_when_finished 'cat actual' && # for debugging only`
`109`	`108`	`git diff -U1 $i >actual &&`
`110`	`109`	`grep '@@ .* @@.*RIGHT' actual`
`111`	`110`	`"`