t: handle EOF in test_copy_bytes()

peff · gitster · commit f7f6dc340ed4 · 2017-07-17T14:55:43.000-07:00
The test_copy_bytes() function claims to read up to N bytes,
or until it gets EOF. But we never handle EOF in our loop,
and a short input will cause perl to go into an infinite
loop of read() getting zero bytes.

Signed-off-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
@@ -999,6 +999,7 @@ test_copy_bytes () {
 			my $s;
 			my $nread = sysread(STDIN, $s, $len);
 			die "cannot read: $!" unless defined($nread);
+			last unless $nread;
 			print $s;
 			$len -= $nread;
 		}

Original file line number	Diff line number	Diff line change
`@@ -999,6 +999,7 @@ test_copy_bytes () {`
`999`	`999`	`my $s;`
`1000`	`1000`	`my $nread = sysread(STDIN, $s, $len);`
`1001`	`1001`	`die "cannot read: $!" unless defined($nread);`
	`1002`	`+ last unless $nread;`
`1002`	`1003`	`print $s;`
`1003`	`1004`	`$len -= $nread;`
`1004`	`1005`	`}`