refs API: make refs_resolve_refdup() not set errno

avar · gitster · commit f65bb9fb06f9 · 2021-10-16T11:17:03.000-07:00
Move refs_resolve_refdup() from the legacy refs_resolve_ref_unsafe()
to the new refs_werrres_ref_unsafe(). I have read its callers and
determined that they don't care about errno being set.

Signed-off-by: Ævar Arnfjörð Bjarmason &lt;avarab@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/refs.c b/refs.c
@@ -268,9 +268,10 @@ char *refs_resolve_refdup(struct ref_store *refs,
 			  struct object_id *oid, int *flags)
 {
 	const char *result;
+	int ignore_errno;
 
-	result = refs_resolve_ref_unsafe(refs, refname, resolve_flags,
-					 oid, flags);
+	result = refs_werrres_ref_unsafe(refs, refname, resolve_flags,
+					 oid, flags, &ignore_errno);
 	return xstrdup_or_null(result);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -268,9 +268,10 @@ char refs_resolve_refdup(struct ref_store refs,`
`268`	`268`	`struct object_id oid, int flags)`
`269`	`269`	`{`
`270`	`270`	`const char *result;`
	`271`	`+ int ignore_errno;`
`271`	`272`
`272`		`- result = refs_resolve_ref_unsafe(refs, refname, resolve_flags,`
`273`		`- oid, flags);`
	`273`	`+ result = refs_werrres_ref_unsafe(refs, refname, resolve_flags,`
	`274`	`+ oid, flags, &ignore_errno);`
`274`	`275`	`return xstrdup_or_null(result);`
`275`	`276`	`}`
`276`	`277`