bisect--helper: BUG() in cmd_*() on invalid subcommand

mirucam · gitster · commit ef5aef5ee0f8 · 2020-08-28T16:21:15.000-07:00
In cmd_bisect__helper() function, if an invalid or no
subcommand is passed there is a BUG.

BUG() out instead of returning an error.

Mentored-by: Christian Couder &lt;chriscool@tuxfamily.org&gt;
Mentored-by: Johannes Schindelin &lt;Johannes.Schindelin@gmx.de&gt;
Signed-off-by: Miriam Rubio &lt;mirucam@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
@@ -720,7 +720,7 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
 		res = bisect_start(&terms, argv, argc);
 		break;
 	default:
-		return error("BUG: unknown subcommand '%d'", cmdmode);
+		BUG("unknown subcommand %d", cmdmode);
 	}
 	free_terms(&terms);
 

Original file line number	Diff line number	Diff line change
`@@ -720,7 +720,7 @@ int cmd_bisect__helper(int argc, const char *argv, const char prefix)`
`720`	`720`	`res = bisect_start(&terms, argv, argc);`
`721`	`721`	`break;`
`722`	`722`	`default:`
`723`		`- return error("BUG: unknown subcommand '%d'", cmdmode);`
	`723`	`+ BUG("unknown subcommand %d", cmdmode);`
`724`	`724`	`}`
`725`	`725`	`free_terms(&terms);`
`726`	`726`