Skip to content

Commit edf9d71

Browse files
committed
Merge branch 'maint'
* maint: gitweb: Always call parse_date with timezone parameter bisect: explain the rationale behind 125
2 parents c41dd2f + 6368d9f commit edf9d71

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

Documentation/git-bisect.txt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,12 @@ exit(3) manual page), as the value is chopped with "& 0377".
241241

242242
The special exit code 125 should be used when the current source code
243243
cannot be tested. If the script exits with this code, the current
244-
revision will be skipped (see `git bisect skip` above).
244+
revision will be skipped (see `git bisect skip` above). 125 was chosen
245+
as the highest sensible value to use for this purpose, because 126 and 127
246+
are used by POSIX shells to signal specific error status (127 is for
247+
command not found, 126 is for command found but not executable---these
248+
details do not matter, as they are normal errors in the script, as far as
249+
"bisect run" is concerned).
245250

246251
You may often find that during a bisect session you want to have
247252
temporary modifications (e.g. s/#define DEBUG 0/#define DEBUG 1/ in a

gitweb/gitweb.perl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4906,7 +4906,6 @@ sub git_log_body {
49064906
next if !%co;
49074907
my $commit = $co{'id'};
49084908
my $ref = format_ref_marker($refs, $commit);
4909-
my %ad = parse_date($co{'author_epoch'});
49104909
git_print_header_div('commit',
49114910
"<span class=\"age\">$co{'age_string'}</span>" .
49124911
esc_html($co{'title'}) . $ref,
@@ -7064,7 +7063,7 @@ sub git_feed {
70647063
if (defined($commitlist[0])) {
70657064
%latest_commit = %{$commitlist[0]};
70667065
my $latest_epoch = $latest_commit{'committer_epoch'};
7067-
%latest_date = parse_date($latest_epoch);
7066+
%latest_date = parse_date($latest_epoch, $latest_commit{'comitter_tz'});
70687067
my $if_modified = $cgi->http('IF_MODIFIED_SINCE');
70697068
if (defined $if_modified) {
70707069
my $since;
@@ -7195,7 +7194,7 @@ sub git_feed {
71957194
if (($i >= 20) && ((time - $co{'author_epoch'}) > 48*60*60)) {
71967195
last;
71977196
}
7198-
my %cd = parse_date($co{'author_epoch'});
7197+
my %cd = parse_date($co{'author_epoch'}, $co{'author_tz'});
71997198

72007199
# get list of changed files
72017200
open my $fd, "-|", git_cmd(), "diff-tree", '-r', @diff_opts,

0 commit comments

Comments
 (0)