Merge branch 'cb/test-lint-cp-a'

gitster · gitster · commit edb3273cd2c9 · 2019-01-14T15:29:30.000-08:00
BSD port update.

* cb/test-lint-cp-a:
  tests: add lint for non portable cp -a
diff --git a/t/check-non-portable-shell.pl b/t/check-non-portable-shell.pl
@@ -35,6 +35,7 @@ sub err {
 		chomp;
 	}
 
+	/\bcp\s+-a/ and err 'cp -a is not portable';
 	/\bsed\s+-i/ and err 'sed -i is not portable';
 	/\becho\s+-[neE]/ and err 'echo with option is not portable (use printf)';
 	/^\s*declare\s+/ and err 'arrays/declare not portable';

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,7 @@ sub err {`
`35`	`35`	`chomp;`
`36`	`36`	`}`
`37`	`37`
	`38`	`+ /\bcp\s+-a/ and err 'cp -a is not portable';`
`38`	`39`	`/\bsed\s+-i/ and err 'sed -i is not portable';`
`39`	`40`	`/\becho\s+-[neE]/ and err 'echo with option is not portable (use printf)';`
`40`	`41`	`/^\s*declare\s+/ and err 'arrays/declare not portable';`