t0021: compute file size with a single process instead of a pipeline

j6t · peff · commit ec2e8b3da21c · 2016-11-08T15:26:40.000-05:00
Avoid unwanted coding patterns (prodigal use of pipelines), and in
particular a useless use of cat.

Signed-off-by: Johannes Sixt &lt;j6t@kdbg.org&gt;
Signed-off-by: Jeff King &lt;peff@peff.net&gt;
diff --git a/t/t0021-conversion.sh b/t/t0021-conversion.sh
@@ -22,7 +22,7 @@ generate_random_characters () {
 }
 
 file_size () {
-	cat "$1" | wc -c | sed "s/^[ ]*//"
+	perl -e 'print -s $ARGV[0]' "$1"
 }
 
 filter_git () {

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ generate_random_characters () {`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`file_size () {`
`25`		`- cat "$1" \| wc -c \| sed "s/^[ ]*//"`
	`25`	`+ perl -e 'print -s $ARGV[0]' "$1"`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`filter_git () {`