wrapper.c: only define gitmkstemps if needed

Ramsay Jones · jrn · commit ec145c9c2ef0 · 2013-10-14T16:16:00.000-07:00
When the NO_MKSTEMPS build variable is not set, the gitmkstemps
function is dead code.  Use a preprocessor conditional to only include
the definition when needed.

Noticed by sparse.  ("'gitmkstemps' was not declared. Should it be
static?")

Signed-off-by: Ramsay Jones &lt;ramsay@ramsay1.demon.co.uk&gt;
Signed-off-by: Jonathan Nieder &lt;jrnieder@gmail.com&gt;
diff --git a/wrapper.c b/wrapper.c
@@ -360,10 +360,12 @@ int git_mkstemp_mode(char *pattern, int mode)
 	return git_mkstemps_mode(pattern, 0, mode);
 }
 
+#ifdef NO_MKSTEMPS
 int gitmkstemps(char *pattern, int suffix_len)
 {
 	return git_mkstemps_mode(pattern, suffix_len, 0600);
 }
+#endif
 
 int xmkstemp_mode(char *template, int mode)
 {

Original file line number	Diff line number	Diff line change
`@@ -360,10 +360,12 @@ int git_mkstemp_mode(char *pattern, int mode)`
`360`	`360`	`return git_mkstemps_mode(pattern, 0, mode);`
`361`	`361`	`}`
`362`	`362`
	`363`	`+#ifdef NO_MKSTEMPS`
`363`	`364`	`int gitmkstemps(char *pattern, int suffix_len)`
`364`	`365`	`{`
`365`	`366`	`return git_mkstemps_mode(pattern, suffix_len, 0600);`
`366`	`367`	`}`
	`368`	`+#endif`
`367`	`369`
`368`	`370`	`int xmkstemp_mode(char *template, int mode)`
`369`	`371`	`{`