for-each-ref: fix objectname:short bug

jaysoffian · gitster · commit ea16a030aaaa · 2010-08-26T16:42:25.000-07:00
When objectname:short was introduced, it forgot to copy the result of
find_unique_abbrev. Because the result of find_unique_abbrev is a
pointer to static buffer, this resulted in the same value being
substituted in for each ref.

Signed-off-by: Jay Soffian &lt;jaysoffian@gmail.com&gt;
Acked-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
@@ -228,7 +228,8 @@ static void grab_common_values(struct atom_value *val, int deref, struct object
 			v->s = s;
 		}
 		else if (!strcmp(name, "objectname:short")) {
-			v->s = find_unique_abbrev(obj->sha1, DEFAULT_ABBREV);
+			v->s = xstrdup(find_unique_abbrev(obj->sha1,
+							  DEFAULT_ABBREV));
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -228,7 +228,8 @@ static void grab_common_values(struct atom_value *val, int deref, struct object`
`228`	`228`	`v->s = s;`
`229`	`229`	`}`
`230`	`230`	`else if (!strcmp(name, "objectname:short")) {`
`231`		`- v->s = find_unique_abbrev(obj->sha1, DEFAULT_ABBREV);`
	`231`	`+ v->s = xstrdup(find_unique_abbrev(obj->sha1,`
	`232`	`+ DEFAULT_ABBREV));`
`232`	`233`	`}`
`233`	`234`	`}`
`234`	`235`	`}`