git-fetch-pack: really do not ask for funny refs

dscho · Junio C Hamano · commit e921fb82cf6f · 2006-01-19T18:29:43.000-08:00
If git-fetch-pack was called with out any refspec, it would ask the server
for funny refs. That cannot work, since the funny refs are not marked
as OUR_REF by upload-pack, which just exits with an error.

Signed-off-by: Johannes Schindelin &lt;Johannes.Schindelin@gmx.de&gt;
Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
diff --git a/fetch-pack.c b/fetch-pack.c
@@ -262,9 +262,6 @@ static void filter_refs(struct ref **refs, int nr_match, char **match)
 {
 	struct ref *prev, *current, *next;
 
-	if (!nr_match)
-		return;
-
 	for (prev = NULL, current = *refs; current; current = next) {
 		next = current->next;
 		if ((!memcmp(current->name, "refs/", 5) &&

Original file line number	Diff line number	Diff line change
`@@ -262,9 +262,6 @@ static void filter_refs(struct ref refs, int nr_match, char match)`
`262`	`262`	`{`
`263`	`263`	`struct ref prev, current, *next;`
`264`	`264`
`265`		`- if (!nr_match)`
`266`		`- return;`
`267`		`-`
`268`	`265`	`for (prev = NULL, current = *refs; current; current = next) {`
`269`	`266`	`next = current->next;`
`270`	`267`	`if ((!memcmp(current->name, "refs/", 5) &&`