gitk: Fix bug where editing an existing view would cause an infinite loop

paulusmack · paulusmack · commit e7297a1c5fd1 · 2008-01-15T22:30:40.000+11:00
This fixes a bug where changing the commit range or file list for an
existing view and then clicking OK would cause gitk to go into an
infinite loop.  The problem was that newviewok was invoking reloadcommits
via "run reloadcommits", but reloadcommits wasn't explicitly returning
0, and whatever it was returning was causing dorunq to run it over
and over again.  This fixes it by making reloadcommits return 0.

Signed-off-by: Paul Mackerras &lt;paulus@samba.org&gt;
diff --git a/gitk b/gitk
@@ -263,6 +263,7 @@ proc reloadcommits {} {
     catch {unset targetid}
     setcanvscroll
     getcommits
+    return 0
 }
 
 # This makes a string representation of a positive integer which

Original file line number	Diff line number	Diff line change
`@@ -263,6 +263,7 @@ proc reloadcommits {} {`
`263`	`263`	`catch {unset targetid}`
`264`	`264`	`setcanvscroll`
`265`	`265`	`getcommits`
	`266`	`+ return 0`
`266`	`267`	`}`
`267`	`268`
`268`	`269`	`# This makes a string representation of a positive integer which`