submodule--helper: plug mem leak in print_default_remote

stefanbeller · gitster · commit e6be8e2f9f87 · 2018-06-01T14:52:47.000+09:00
Signed-off-by: Stefan Beller &lt;sbeller@google.com&gt;
Acked-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;
[jc: no need for remote to be const char *]
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
@@ -55,7 +55,7 @@ static char *get_default_remote(void)
 
 static int print_default_remote(int argc, const char **argv, const char *prefix)
 {
-	const char *remote;
+	char *remote;
 
 	if (argc != 1)
 		die(_("submodule--helper print-default-remote takes no arguments"));
@@ -64,6 +64,7 @@ static int print_default_remote(int argc, const char **argv, const char *prefix)
 	if (remote)
 		printf("%s\n", remote);
 
+	free(remote);
 	return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ static char *get_default_remote(void)`
`55`	`55`
`56`	`56`	`static int print_default_remote(int argc, const char *argv, const char prefix)`
`57`	`57`	`{`
`58`		`- const char *remote;`
	`58`	`+ char *remote;`
`59`	`59`
`60`	`60`	`if (argc != 1)`
`61`	`61`	`die(_("submodule--helper print-default-remote takes no arguments"));`
`@@ -64,6 +64,7 @@ static int print_default_remote(int argc, const char *argv, const char prefix)`
`64`	`64`	`if (remote)`
`65`	`65`	`printf("%s\n", remote);`
`66`	`66`
	`67`	`+ free(remote);`
`67`	`68`	`return 0;`
`68`	`69`	`}`
`69`	`70`