tests: don't give unportable ">" to "test" built-in, use -gt

avar · gitster · commit dff2813391d7 · 2017-08-07T10:32:11.000-07:00
Change an argument to test_line_count (which'll ultimately be turned into a "test" expression) to use "-gt" instead of ">" for an arithmetic test. This broken on e.g. OpenBSD as of v2.13.0 with my commit ac3f5a3 ("ref-filter: add --no-contains option to tag/branch/for-each-ref", 2017-03-24). Downstream just worked around it by patching git and didn't tell us about it, I discovered this when reading various Git packaging implementations: openbsd/ports@7e48bf88a20 Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
@@ -1889,7 +1889,7 @@ EOF"
 	run_with_limited_stack git tag --contains HEAD >actual &&
 	test_cmp expect actual &&
 	run_with_limited_stack git tag --no-contains HEAD >actual &&
-	test_line_count ">" 10 actual
+	test_line_count "-gt" 10 actual
 '
 
 test_expect_success '--format should list tags as per format given' '

Original file line number	Diff line number	Diff line change
`@@ -1889,7 +1889,7 @@ EOF"`
`1889`	`1889`	`run_with_limited_stack git tag --contains HEAD >actual &&`
`1890`	`1890`	`test_cmp expect actual &&`
`1891`	`1891`	`run_with_limited_stack git tag --no-contains HEAD >actual &&`
`1892`		`- test_line_count ">" 10 actual`
	`1892`	`+ test_line_count "-gt" 10 actual`
`1893`	`1893`	`'`
`1894`	`1894`
`1895`	`1895`	`test_expect_success '--format should list tags as per format given' '`