t8001/t8002: blame: demonstrate acceptance of bogus -LX,+0 and -LX,-0

sunshineco · gitster · commit dedb9129d472 · 2013-08-05T11:54:32.000-07:00
Empty ranges -LX,+0 and -LX,-0 are nonsensical in the context of blame
yet they are accepted. They should be errors. Demonstrate this
shortcoming.

Signed-off-by: Eric Sunshine &lt;sunshine@sunshineco.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/annotate-tests.sh b/t/annotate-tests.sh
@@ -185,6 +185,10 @@ test_expect_success 'blame -L Y,X (undocumented)' '
 	check_count -L6,3 B 1 B1 1 B2 1 D 1
 '
 
+test_expect_failure 'blame -L X,+0' '
+	test_must_fail $PROG -L1,+0 file
+'
+
 test_expect_success 'blame -L X,+1' '
 	check_count -L3,+1 B2 1
 '
@@ -193,6 +197,10 @@ test_expect_success 'blame -L X,+N' '
 	check_count -L3,+4 B 1 B1 1 B2 1 D 1
 '
 
+test_expect_failure 'blame -L X,-0' '
+	test_must_fail $PROG -L1,-0 file
+'
+
 test_expect_success 'blame -L X,-1' '
 	check_count -L3,-1 B2 1
 '

Original file line number	Diff line number	Diff line change
`@@ -185,6 +185,10 @@ test_expect_success 'blame -L Y,X (undocumented)' '`
`185`	`185`	`check_count -L6,3 B 1 B1 1 B2 1 D 1`
`186`	`186`	`'`
`187`	`187`
	`188`	`+test_expect_failure 'blame -L X,+0' '`
	`189`	`+ test_must_fail $PROG -L1,+0 file`
	`190`	`+'`
	`191`	`+`
`188`	`192`	`test_expect_success 'blame -L X,+1' '`
`189`	`193`	`check_count -L3,+1 B2 1`
`190`	`194`	`'`
`@@ -193,6 +197,10 @@ test_expect_success 'blame -L X,+N' '`
`193`	`197`	`check_count -L3,+4 B 1 B1 1 B2 1 D 1`
`194`	`198`	`'`
`195`	`199`
	`200`	`+test_expect_failure 'blame -L X,-0' '`
	`201`	`+ test_must_fail $PROG -L1,-0 file`
	`202`	`+'`
	`203`	`+`
`196`	`204`	`test_expect_success 'blame -L X,-1' '`
`197`	`205`	`check_count -L3,-1 B2 1`
`198`	`206`	`'`