use xstrdup please

spearce · Junio C Hamano · commit dbb2b41aa49a · 2007-03-16T02:12:14.000-07:00
We generally prefer xstrdup to just plain strdup.
Make it so.

Signed-off-by: Shawn O. Pearce &lt;spearce@spearce.org&gt;
Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
diff --git a/config.c b/config.c
@@ -351,12 +351,12 @@ int git_default_config(const char *var, const char *value)
 	}
 
 	if (!strcmp(var, "i18n.commitencoding")) {
-		git_commit_encoding = strdup(value);
+		git_commit_encoding = xstrdup(value);
 		return 0;
 	}
 
 	if (!strcmp(var, "i18n.logoutputencoding")) {
-		git_log_output_encoding = strdup(value);
+		git_log_output_encoding = xstrdup(value);
 		return 0;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -351,12 +351,12 @@ int git_default_config(const char var, const char value)`
`351`	`351`	`}`
`352`	`352`
`353`	`353`	`if (!strcmp(var, "i18n.commitencoding")) {`
`354`		`- git_commit_encoding = strdup(value);`
	`354`	`+ git_commit_encoding = xstrdup(value);`
`355`	`355`	`return 0;`
`356`	`356`	`}`
`357`	`357`
`358`	`358`	`if (!strcmp(var, "i18n.logoutputencoding")) {`
`359`		`- git_log_output_encoding = strdup(value);`
	`359`	`+ git_log_output_encoding = xstrdup(value);`
`360`	`360`	`return 0;`
`361`	`361`	`}`
`362`	`362`