fetch: if not fetching from default remote, ignore default merge

dscho · spearce · commit da0204df587a · 2007-10-16T01:24:18.000-04:00
When doing "git fetch &lt;remote&gt;" on a remote that does not have the
branch referenced in branch.&lt;current-branch&gt;.merge, git fetch failed.
It failed because it tried to add the "merge" ref to the refs to be
fetched.

Fix that.  And add a test case.

Incidentally, this unconvered a bug in our own test suite, where
"git pull &lt;some-path&gt;" was expected to merge the ref given in the
defaults, even if not pulling from the default remote.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;
Signed-off-by: Lars Hjemli &lt;hjemli@gmail.com&gt;
Signed-off-by: Shawn O. Pearce &lt;spearce@spearce.org&gt;
diff --git a/builtin-fetch.c b/builtin-fetch.c
@@ -105,7 +105,13 @@ static struct ref *get_ref_map(struct transport *transport,
 				    !remote->fetch[0].pattern)
 					ref_map->merge = 1;
 			}
-			if (has_merge)
+			/*
+			 * if the remote we're fetching from is the same
+			 * as given in branch.<name>.remote, we add the
+			 * ref given in branch.<name>.merge, too.
+			 */
+			if (has_merge && !strcmp(branch->remote_name,
+						remote->name))
 				add_merge_config(&ref_map, remote_refs, branch, &tail);
 		} else {
 			ref_map = get_remote_ref(remote_refs, "HEAD");
diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh
@@ -200,4 +200,12 @@ test_expect_success 'push via rsync' '
 '
 }
 
+test_expect_success 'fetch with a non-applying branch.<name>.merge' '
+	git config branch.master.remote yeti &&
+	git config branch.master.merge refs/heads/bigfoot &&
+	git config remote.blub.url one &&
+	git config remote.blub.fetch "refs/heads/*:refs/remotes/one/*" &&
+	git fetch blub
+'
+
 test_done
diff --git a/t/t5700-clone-reference.sh b/t/t5700-clone-reference.sh
@@ -38,7 +38,7 @@ cd "$base_dir"
 
 test_expect_success 'pulling from reference' \
 'cd C &&
-git pull ../B'
+git pull ../B master'
 
 cd "$base_dir"
 
@@ -61,7 +61,7 @@ test_expect_success 'existence of info/alternates' \
 cd "$base_dir"
 
 test_expect_success 'pulling from reference' \
-'cd D && git pull ../B'
+'cd D && git pull ../B master'
 
 cd "$base_dir"
 

Original file line number	Diff line number	Diff line change
`@@ -200,4 +200,12 @@ test_expect_success 'push via rsync' '`
`200`	`200`	`'`
`201`	`201`	`}`
`202`	`202`
	`203`	`+test_expect_success 'fetch with a non-applying branch.<name>.merge' '`
	`204`	`+ git config branch.master.remote yeti &&`
	`205`	`+ git config branch.master.merge refs/heads/bigfoot &&`
	`206`	`+ git config remote.blub.url one &&`
	`207`	`+ git config remote.blub.fetch "refs/heads/:refs/remotes/one/" &&`
	`208`	`+ git fetch blub`
	`209`	`+'`
	`210`	`+`
`203`	`211`	`test_done`