rev-parse test: use test_must_fail, not "if <command>; then false; fi"

felipec · gitster · commit d8f7681337dd · 2013-09-03T12:54:52.000-07:00
This way, if rev-parse segfaults then the test will fail instead
of treating it the same way as a controlled failure.

Signed-off-by: Felipe Contreras &lt;felipe.contreras@gmail.com&gt;
Signed-off-by: Jonathan Nieder &lt;jrnieder@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/t6101-rev-parse-parents.sh b/t/t6101-rev-parse-parents.sh
@@ -26,7 +26,7 @@ test_expect_success 'start^0' '
 '
 
 test_expect_success 'start^1 not valid' '
-	if git rev-parse --verify start^1; then false; else :; fi
+	test_must_fail git rev-parse --verify start^1
 '
 
 test_expect_success 'second^1 = second^' '
@@ -50,7 +50,7 @@ test_expect_success 'final^1^2 != final^1^1' '
 '
 
 test_expect_success 'final^1^3 not valid' '
-	if git rev-parse --verify final^1^3; then false; else :; fi
+	test_must_fail git rev-parse --verify final^1^3
 '
 
 test_expect_success '--verify start2^1' '

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ test_expect_success 'start^0' '`
`26`	`26`	`'`
`27`	`27`
`28`	`28`	`test_expect_success 'start^1 not valid' '`
`29`		`- if git rev-parse --verify start^1; then false; else :; fi`
	`29`	`+ test_must_fail git rev-parse --verify start^1`
`30`	`30`	`'`
`31`	`31`
`32`	`32`	`test_expect_success 'second^1 = second^' '`
`@@ -50,7 +50,7 @@ test_expect_success 'final^1^2 != final^1^1' '`
`50`	`50`	`'`
`51`	`51`
`52`	`52`	`test_expect_success 'final^1^3 not valid' '`
`53`		`- if git rev-parse --verify final^1^3; then false; else :; fi`
	`53`	`+ test_must_fail git rev-parse --verify final^1^3`
`54`	`54`	`'`
`55`	`55`
`56`	`56`	`test_expect_success '--verify start2^1' '`