Skip to content

Commit d42453a

Browse files
mhaggergitster
authored andcommitted
Remove anachronism from comment
Setting attributes to arbitrary values ("attribute=value") is now supported, so it is no longer necessary for this comment to justify prohibiting '=' in an attribute name. Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 650cfc5 commit d42453a

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

attr.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,8 @@ static unsigned hash_name(const char *name, int namelen)
5050
static int invalid_attr_name(const char *name, int namelen)
5151
{
5252
/*
53-
* Attribute name cannot begin with '-' and from
54-
* [-A-Za-z0-9_.]. We'd specifically exclude '=' for now,
55-
* as we might later want to allow non-binary value for
56-
* attributes, e.g. "*.svg merge=special-merge-program-for-svg"
53+
* Attribute name cannot begin with '-' and must consist of
54+
* characters from [-A-Za-z0-9_.].
5755
*/
5856
if (*name == '-')
5957
return -1;

0 commit comments

Comments
 (0)