parse-remote: mark all refs not for merge only when fetching more than one

Junio C Hamano · Junio C Hamano · commit d41cb273d313 · 2006-12-21T22:56:25.000-08:00
An earlier commit a71fb0a implemented much requested safety valve to refuse "git pull" or "git pull origin" without explicit refspecs from using the first set of remote refs obtained by reading .git/remotes/origin file or branch.*.fetch configuration variables to create a merge. The argument was that while on a branch different from the default branch, it is often wrong to merge the default remote ref suitable for merging into the master. That is fine as a theory. But many repositories already in use by people in the real world do not have any of the per branch configuration crap. They did not need it, and they do not need it now. Merging with the first remote ref listed was just fine, because they had only one ref (e.g. 'master' from linux-2.6.git) anyway. So this changes the safety valve to be a lot looser. When "git fetch" gets only one remote branch, the irritating warning would not trigger anymore. I think we could also make the warning trigger when branch.*.merge is not specified for the current branch, but is for some other branch. That is for another commit. Signed-off-by: Junio C Hamano <junkio@cox.net>
diff --git a/git-parse-remote.sh b/git-parse-remote.sh
@@ -136,15 +136,22 @@ canon_refs_list_for_fetch () {
 	if test "$1" = "-d"
 	then
 		shift ; remote="$1" ; shift
+		set x $(expand_refs_wildcard "$@")
+		shift
 		if test "$remote" = "$(get_default_remote)"
 		then
 			curr_branch=$(git-symbolic-ref HEAD | \
 			    sed -e 's|^refs/heads/||')
 			merge_branches=$(git-repo-config \
 			    --get-all "branch.${curr_branch}.merge")
 		fi
-		set x $(expand_refs_wildcard "$@")
-		shift
+		# If we are fetching only one branch, then first branch
+		# is the only thing that makes sense to merge anyway,
+		# so there is no point refusing that traditional rule.
+		if test $# != 1 && test "z$merge_branches" = z
+		then
+			merge_branches=..this..would..never..match..
+		fi
 	fi
 	for ref
 	do
