Skip to content

Commit d16ec9c

Browse files
pcloudsgitster
pclouds
authored and
gitster
committed
revision.h: drop extern from function declaration
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent c2ec417 commit d16ec9c

File tree

1 file changed

+35
-34
lines changed

1 file changed

+35
-34
lines changed

‎revision.h‎

Lines changed: 35 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ struct rev_info {
230230
struct revision_sources *sources;
231231
};
232232

233-
extern int ref_excluded(struct string_list *, const char *path);
233+
int ref_excluded(struct string_list *, const char *path);
234234
void clear_ref_exclusion(struct string_list **);
235235
void add_ref_exclusion(struct string_list **, const char *exclude);
236236

@@ -252,50 +252,50 @@ struct setup_revision_opt {
252252
unsigned revarg_opt;
253253
};
254254

255-
extern void init_revisions(struct rev_info *revs, const char *prefix);
256-
extern int setup_revisions(int argc, const char **argv, struct rev_info *revs,
257-
struct setup_revision_opt *);
258-
extern void parse_revision_opt(struct rev_info *revs, struct parse_opt_ctx_t *ctx,
259-
const struct option *options,
260-
const char * const usagestr[]);
255+
void init_revisions(struct rev_info *revs, const char *prefix);
256+
int setup_revisions(int argc, const char **argv, struct rev_info *revs,
257+
struct setup_revision_opt *);
258+
void parse_revision_opt(struct rev_info *revs, struct parse_opt_ctx_t *ctx,
259+
const struct option *options,
260+
const char * const usagestr[]);
261261
#define REVARG_CANNOT_BE_FILENAME 01
262262
#define REVARG_COMMITTISH 02
263-
extern int handle_revision_arg(const char *arg, struct rev_info *revs,
264-
int flags, unsigned revarg_opt);
263+
int handle_revision_arg(const char *arg, struct rev_info *revs,
264+
int flags, unsigned revarg_opt);
265265

266-
extern void reset_revision_walk(void);
267-
extern int prepare_revision_walk(struct rev_info *revs);
268-
extern struct commit *get_revision(struct rev_info *revs);
269-
extern char *get_revision_mark(const struct rev_info *revs,
270-
const struct commit *commit);
271-
extern void put_revision_mark(const struct rev_info *revs,
272-
const struct commit *commit);
266+
void reset_revision_walk(void);
267+
int prepare_revision_walk(struct rev_info *revs);
268+
struct commit *get_revision(struct rev_info *revs);
269+
char *get_revision_mark(const struct rev_info *revs,
270+
const struct commit *commit);
271+
void put_revision_mark(const struct rev_info *revs,
272+
const struct commit *commit);
273273

274-
extern void mark_parents_uninteresting(struct commit *commit);
275-
extern void mark_tree_uninteresting(struct tree *tree);
274+
void mark_parents_uninteresting(struct commit *commit);
275+
void mark_tree_uninteresting(struct tree *tree);
276276

277-
extern void show_object_with_name(FILE *, struct object *, const char *);
277+
void show_object_with_name(FILE *, struct object *, const char *);
278278

279-
extern void add_pending_object(struct rev_info *revs,
280-
struct object *obj, const char *name);
281-
extern void add_pending_oid(struct rev_info *revs,
282-
const char *name, const struct object_id *oid,
283-
unsigned int flags);
279+
void add_pending_object(struct rev_info *revs,
280+
struct object *obj, const char *name);
281+
void add_pending_oid(struct rev_info *revs,
282+
const char *name, const struct object_id *oid,
283+
unsigned int flags);
284284

285-
extern void add_head_to_pending(struct rev_info *);
286-
extern void add_reflogs_to_pending(struct rev_info *, unsigned int flags);
287-
extern void add_index_objects_to_pending(struct rev_info *, unsigned int flags);
285+
void add_head_to_pending(struct rev_info *);
286+
void add_reflogs_to_pending(struct rev_info *, unsigned int flags);
287+
void add_index_objects_to_pending(struct rev_info *, unsigned int flags);
288288

289289
enum commit_action {
290290
commit_ignore,
291291
commit_show,
292292
commit_error
293293
};
294294

295-
extern enum commit_action get_commit_action(struct rev_info *revs,
296-
struct commit *commit);
297-
extern enum commit_action simplify_commit(struct rev_info *revs,
298-
struct commit *commit);
295+
enum commit_action get_commit_action(struct rev_info *revs,
296+
struct commit *commit);
297+
enum commit_action simplify_commit(struct rev_info *revs,
298+
struct commit *commit);
299299

300300
enum rewrite_result {
301301
rewrite_one_ok,
@@ -305,8 +305,9 @@ enum rewrite_result {
305305

306306
typedef enum rewrite_result (*rewrite_parent_fn_t)(struct rev_info *revs, struct commit **pp);
307307

308-
extern int rewrite_parents(struct rev_info *revs, struct commit *commit,
309-
rewrite_parent_fn_t rewrite_parent);
308+
int rewrite_parents(struct rev_info *revs,
309+
struct commit *commit,
310+
rewrite_parent_fn_t rewrite_parent);
310311

311312
/*
312313
* The log machinery saves the original parent list so that
@@ -317,6 +318,6 @@ extern int rewrite_parents(struct rev_info *revs, struct commit *commit,
317318
* get_saved_parents() will transparently return commit->parents if
318319
* history simplification is off.
319320
*/
320-
extern struct commit_list *get_saved_parents(struct rev_info *revs, const struct commit *commit);
321+
struct commit_list *get_saved_parents(struct rev_info *revs, const struct commit *commit);
321322

322323
#endif

0 commit comments

Comments
 (0)