print warning/error/fatal messages in one shot

Nicolas Pitre · gitster · commit d048a96ee9be · 2007-11-09T22:25:36.000-08:00
Not doing so is likely to create a messed up display when sent over the
sideband protocol.

Signed-off-by: Nicolas Pitre &lt;nico@cam.org&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/usage.c b/usage.c
@@ -7,9 +7,9 @@
 
 static void report(const char *prefix, const char *err, va_list params)
 {
-	fputs(prefix, stderr);
-	vfprintf(stderr, err, params);
-	fputs("\n", stderr);
+	char msg[256];
+	vsnprintf(msg, sizeof(msg), err, params);
+	fprintf(stderr, "%s%s\n", prefix, msg);
 }
 
 static NORETURN void usage_builtin(const char *err)

Original file line number	Diff line number	Diff line change
`@@ -7,9 +7,9 @@`
`7`	`7`
`8`	`8`	`static void report(const char prefix, const char err, va_list params)`
`9`	`9`	`{`
`10`		`- fputs(prefix, stderr);`
`11`		`- vfprintf(stderr, err, params);`
`12`		`- fputs("\n", stderr);`
	`10`	`+ char msg[256];`
	`11`	`+ vsnprintf(msg, sizeof(msg), err, params);`
	`12`	`+ fprintf(stderr, "%s%s\n", prefix, msg);`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`static NORETURN void usage_builtin(const char *err)`