Fix filehandle leak in "git branch -D"

raalkml · gitster · commit cbbb218f8bd2 · 2007-08-10T22:50:06.000-07:00
On Windows (it can't touch open files in any way) the following fails:

    git branch -D branch1 branch2

if the both branches are in packed-refs.

Signed-off-by: Alex Riesen &lt;raa.lkml@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/refs.c b/refs.c
@@ -869,6 +869,7 @@ static int repack_without_ref(const char *refname)
 			die("too long a refname '%s'", list->name);
 		write_or_die(fd, line, len);
 	}
+	close(fd);
 	return commit_lock_file(&packlock);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -869,6 +869,7 @@ static int repack_without_ref(const char *refname)`
`869`	`869`	`die("too long a refname '%s'", list->name);`
`870`	`870`	`write_or_die(fd, line, len);`
`871`	`871`	`}`
	`872`	`+ close(fd);`
`872`	`873`	`return commit_lock_file(&packlock);`
`873`	`874`	`}`
`874`	`875`