git-commit: partial commit of paths only removed from the index

gitster · gitster · commit cba8d4896187 · 2007-09-17T23:57:35.000-07:00
Because a partial commit is meant to be a way to ignore what are
staged in the index, "git rm --cached A &amp;&amp; git commit A" should
just record what is in A on the filesystem.  The previous patch
made the command sequence to barf, saying that A has not been
added yet.  This fixes it.

Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/git-commit.sh b/git-commit.sh
@@ -404,7 +404,7 @@ t,)
 		(
 			GIT_INDEX_FILE="$NEXT_INDEX"
 			export GIT_INDEX_FILE
-			git update-index --remove --stdin
+			git update-index --add --remove --stdin
 		) || exit
 		;;
 	esac
diff --git a/t/t7501-commit.sh b/t/t7501-commit.sh
@@ -131,7 +131,7 @@ test_expect_success \
     'validate git-rev-list output.' \
     'diff current expected'
 
-test_expect_success 'partial commit that involve removal (1)' '
+test_expect_success 'partial commit that involves removal (1)' '
 
 	git rm --cached file &&
 	mv file elif &&
@@ -143,7 +143,7 @@ test_expect_success 'partial commit that involve removal (1)' '
 
 '
 
-test_expect_success 'partial commit that involve removal (2)' '
+test_expect_success 'partial commit that involves removal (2)' '
 
 	git commit -m "Partial: remove file" file &&
 	git diff-tree --name-status HEAD^ HEAD >current &&
@@ -152,4 +152,15 @@ test_expect_success 'partial commit that involve removal (2)' '
 
 '
 
+test_expect_success 'partial commit that involves removal (3)' '
+
+	git rm --cached elif &&
+	echo elif >elif &&
+	git commit -m "Partial: modify elif" elif &&
+	git diff-tree --name-status HEAD^ HEAD >current &&
+	echo "M	elif" >expected &&
+	diff expected current
+
+'
+
 test_done

Original file line number	Diff line number	Diff line change
`@@ -404,7 +404,7 @@ t,)`
`404`	`404`	`(`
`405`	`405`	`GIT_INDEX_FILE="$NEXT_INDEX"`
`406`	`406`	`export GIT_INDEX_FILE`
`407`		`- git update-index --remove --stdin`
	`407`	`+ git update-index --add --remove --stdin`
`408`	`408`	`) \|\| exit`
`409`	`409`	`;;`
`410`	`410`	`esac`