Teach diff to imply --find-copies-harder upon -C -C

dscho · gitster · commit ca6c097089a3 · 2007-06-12T01:00:38.000-07:00
Earlier, a second "-C" on the command line had no effect.
But "--find-copies-harder" is so long to type, let's make doubled -C
enable that option.  It is in line with how "git blame" handles such
doubled options to mean "work harder".

Signed-off-by: Johannes Schindelin &lt;Johannes.Schindelin@gmx.de&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
@@ -86,7 +86,7 @@
 	Detect renames.
 
 -C::
-	Detect copies as well as renames.
+	Detect copies as well as renames.  See also `--find-copies-harder`.
 
 --diff-filter=[ACDMRTUXB*]::
 	Select only files that are Added (`A`), Copied (`C`),
@@ -100,12 +100,13 @@
 	that matches other criteria, nothing is selected.
 
 --find-copies-harder::
-	For performance reasons, by default, -C option finds copies only
+	For performance reasons, by default, `-C` option finds copies only
 	if the original file of the copy was modified in the same
 	changeset.  This flag makes the command
 	inspect unmodified files as candidates for the source of
 	copy.  This is a very expensive operation for large
-	projects, so use it with caution.
+	projects, so use it with caution.  Giving more than one
+	`-C` option has the same effect.
 
 -l<num>::
 	-M and -C options require O(n^2) processing time where n
diff --git a/diff.c b/diff.c
@@ -2201,6 +2201,8 @@ int diff_opt_parse(struct diff_options *options, const char **av, int ac)
 		options->detect_rename = DIFF_DETECT_RENAME;
 	}
 	else if (!prefixcmp(arg, "-C")) {
+		if (options->detect_rename == DIFF_DETECT_COPY)
+			options->find_copies_harder = 1;
 		if ((options->rename_score =
 		     diff_scoreopt_parse(arg)) == -1)
 			return -1;

Original file line number	Diff line number	Diff line change
`@@ -2201,6 +2201,8 @@ int diff_opt_parse(struct diff_options options, const char *av, int ac)`
`2201`	`2201`	`options->detect_rename = DIFF_DETECT_RENAME;`
`2202`	`2202`	`}`
`2203`	`2203`	`else if (!prefixcmp(arg, "-C")) {`
	`2204`	`+ if (options->detect_rename == DIFF_DETECT_COPY)`
	`2205`	`+ options->find_copies_harder = 1;`
`2204`	`2206`	`if ((options->rename_score =`
`2205`	`2207`	`diff_scoreopt_parse(arg)) == -1)`
`2206`	`2208`	`return -1;`