Do not drop data from '\0' until eol in patch output

Stephan Feder · Junio C Hamano · commit c9c95bbc9c9f · 2006-07-07T03:48:10.000-07:00
The binary file detection is just a heuristic which can well fail.
Do not produce garbage patches in these cases.

Signed-off-by: Stephan Feder &lt;sf@b-i-t.de&gt;
Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
diff --git a/diff.c b/diff.c
@@ -329,7 +329,9 @@ static void fn_out_consume(void *priv, char *line, unsigned long len)
 	}
 	if (len > 0 && line[len-1] == '\n')
 		len--;
-	printf("%s%.*s%s\n", set, (int) len, line, reset);
+	fputs (set, stdout);
+	fwrite (line, len, 1, stdout);
+	puts (reset);
 }
 
 static char *pprint_rename(const char *a, const char *b)

Original file line number	Diff line number	Diff line change
`@@ -329,7 +329,9 @@ static void fn_out_consume(void priv, char line, unsigned long len)`
`329`	`329`	`}`
`330`	`330`	`if (len > 0 && line[len-1] == '\n')`
`331`	`331`	`len--;`
`332`		`- printf("%s%.*s%s\n", set, (int) len, line, reset);`
	`332`	`+ fputs (set, stdout);`
	`333`	`+ fwrite (line, len, 1, stdout);`
	`334`	`+ puts (reset);`
`333`	`335`	`}`
`334`	`336`
`335`	`337`	`static char pprint_rename(const char a, const char *b)`