Skip to content

Commit c8f7c8b

Browse files
tboegigitster
tboegi
authored and
gitster
committed
t0027: tests are not expensive; remove t0025
The purpose of t0027 is to test all CRLF related conversions at "git checkout" and "git add". Running t0027 under Git for Windows takes 3-4 minutes, so the whole script had been marked as "EXPENSIVE". However, the "Git for Windows" fork overrides this since 2014: "t0027 is marked expensive, but really, for MinGW we want to run these tests always." The test seems not to be expensive on other platforms at all: it takes less than 14 seconds under Linux, and 63 seconds under Mac Os X, and this is more or less the same with a SSD or a spinning disk. So let's drop the "EXPENSIVE" prereq. While at it, retire t0025; recent "stress" tests show that t0025 is flaky, reported by Lars Schneider <larsxschneider@gmail.com>, but all tests in t0025 are covered by t0027 already. Signed-off-by: Torsten Bögershausen <tboegi@web.de> Acked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 027a3b9 commit c8f7c8b

File tree

2 files changed

+0
-187
lines changed

2 files changed

+0
-187
lines changed

‎t/t0025-crlf-auto.sh‎

Lines changed: 0 additions & 181 deletions
This file was deleted.

‎t/t0027-auto-crlf.sh‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,6 @@ test_description='CRLF conversion all combinations'
44

55
. ./test-lib.sh
66

7-
if ! test_have_prereq EXPENSIVE
8-
then
9-
skip_all="EXPENSIVE not set"
10-
test_done
11-
fi
12-
137
compare_files () {
148
tr '\015\000' QN <"$1" >"$1".expect &&
159
tr '\015\000' QN <"$2" | tr -d 'Z' >"$2".actual &&

0 commit comments

Comments
 (0)