mergetool--lib: add p4merge as a pre-configured mergetool option

schacon · gitster · commit c8998b4823cb · 2009-10-28T16:48:20.000-07:00
Add p4merge to the set of built-in diff/merge tools, and update
bash completion and documentation.

Signed-off-by: Scott Chacon &lt;schacon@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/Documentation/git-difftool.txt b/Documentation/git-difftool.txt
@@ -31,7 +31,7 @@ OPTIONS
 	Use the diff tool specified by <tool>.
 	Valid merge tools are:
 	kdiff3, kompare, tkdiff, meld, xxdiff, emerge, vimdiff, gvimdiff,
-	ecmerge, diffuse, opendiff and araxis.
+	ecmerge, diffuse, opendiff, p4merge and araxis.
 +
 If a diff tool is not specified, 'git-difftool'
 will use the configuration variable `diff.tool`.  If the
diff --git a/Documentation/git-mergetool.txt b/Documentation/git-mergetool.txt
@@ -27,7 +27,7 @@ OPTIONS
 	Use the merge resolution program specified by <tool>.
 	Valid merge tools are:
 	kdiff3, tkdiff, meld, xxdiff, emerge, vimdiff, gvimdiff, ecmerge,
-	diffuse, tortoisemerge, opendiff and araxis.
+	diffuse, tortoisemerge, opendiff, p4merge and araxis.
 +
 If a merge resolution program is not specified, 'git-mergetool'
 will use the configuration variable `merge.tool`.  If the
diff --git a/Documentation/merge-config.txt b/Documentation/merge-config.txt
@@ -23,7 +23,7 @@ merge.tool::
 	Controls which merge resolution program is used by
 	linkgit:git-mergetool[1].  Valid built-in values are: "kdiff3",
 	"tkdiff", "meld", "xxdiff", "emerge", "vimdiff", "gvimdiff",
-	"diffuse", "ecmerge", "tortoisemerge", "araxis", and
+	"diffuse", "ecmerge", "tortoisemerge", "p4merge", "araxis" and
 	"opendiff".  Any other value is treated is custom merge tool
 	and there must be a corresponding mergetool.<tool>.cmd option.
 
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
@@ -953,7 +953,7 @@ _git_diff ()
 }
 
 __git_mergetools_common="diffuse ecmerge emerge kdiff3 meld opendiff
-			tkdiff vimdiff gvimdiff xxdiff araxis
+			tkdiff vimdiff gvimdiff xxdiff araxis p4merge
 "
 
 _git_difftool ()
diff --git a/git-mergetool--lib.sh b/git-mergetool--lib.sh
@@ -46,7 +46,7 @@ check_unchanged () {
 valid_tool () {
 	case "$1" in
 	kdiff3 | tkdiff | xxdiff | meld | opendiff | \
-	emerge | vimdiff | gvimdiff | ecmerge | diffuse | araxis)
+	emerge | vimdiff | gvimdiff | ecmerge | diffuse | araxis | p4merge)
 		;; # happy
 	tortoisemerge)
 		if ! merge_mode; then
@@ -130,6 +130,19 @@ run_merge_tool () {
 			"$merge_tool_path" "$LOCAL" "$REMOTE"
 		fi
 		;;
+	p4merge)
+		if merge_mode; then
+		    touch "$BACKUP"
+			if $base_present; then
+				"$merge_tool_path" "$BASE" "$LOCAL" "$REMOTE" "$MERGED"
+			else
+				"$merge_tool_path" "$LOCAL" "$LOCAL" "$REMOTE" "$MERGED"
+			fi
+			check_unchanged
+		else
+			"$merge_tool_path" "$LOCAL" "$REMOTE"
+		fi
+		;;
 	meld)
 		if merge_mode; then
 			touch "$BACKUP"
@@ -323,7 +336,7 @@ guess_merge_tool () {
 		else
 			tools="opendiff kdiff3 tkdiff xxdiff meld $tools"
 		fi
-		tools="$tools gvimdiff diffuse ecmerge araxis"
+		tools="$tools gvimdiff diffuse ecmerge p4merge araxis"
 	fi
 	if echo "${VISUAL:-$EDITOR}" | grep emacs > /dev/null 2>&1; then
 		# $EDITOR is emacs so add emerge as a candidate

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ OPTIONS`
`31`	`31`	`Use the diff tool specified by <tool>.`
`32`	`32`	`Valid merge tools are:`
`33`	`33`	`kdiff3, kompare, tkdiff, meld, xxdiff, emerge, vimdiff, gvimdiff,`
`34`		`- ecmerge, diffuse, opendiff and araxis.`
	`34`	`+ ecmerge, diffuse, opendiff, p4merge and araxis.`
`35`	`35`	`+`
`36`	`36`	`If a diff tool is not specified, 'git-difftool'`
`37`	`37`	will use the configuration variable `diff.tool`. If the
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ OPTIONS`
`27`	`27`	`Use the merge resolution program specified by <tool>.`
`28`	`28`	`Valid merge tools are:`
`29`	`29`	`kdiff3, tkdiff, meld, xxdiff, emerge, vimdiff, gvimdiff, ecmerge,`
`30`		`- diffuse, tortoisemerge, opendiff and araxis.`
	`30`	`+ diffuse, tortoisemerge, opendiff, p4merge and araxis.`
`31`	`31`	`+`
`32`	`32`	`If a merge resolution program is not specified, 'git-mergetool'`
`33`	`33`	will use the configuration variable `merge.tool`. If the
Original file line number	Diff line number	Diff line change
`@@ -953,7 +953,7 @@ _git_diff ()`
`953`	`953`	`}`
`954`	`954`
`955`	`955`	`__git_mergetools_common="diffuse ecmerge emerge kdiff3 meld opendiff`
`956`		`- tkdiff vimdiff gvimdiff xxdiff araxis`
	`956`	`+ tkdiff vimdiff gvimdiff xxdiff araxis p4merge`
`957`	`957`	`"`
`958`	`958`
`959`	`959`	`_git_difftool ()`