bisect: call 'clear_commit_marks_all()' in 'bisect_next_all()'

mirucam · gitster · commit c7a7f48f4fe8 · 2020-09-24T12:06:30.000-07:00
As there can be other revision walks after bisect_next_all(),
let's add a call to a function to clear all the marks at the
end of bisect_next_all().

Mentored-by: Christian Couder &lt;chriscool@tuxfamily.org&gt;
Signed-off-by: Miriam Rubio &lt;mirucam@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/bisect.c b/bisect.c
@@ -1082,6 +1082,8 @@ enum bisect_error bisect_next_all(struct repository *r, const char *prefix)
 		  "Bisecting: %d revisions left to test after this %s\n",
 		  nr), nr, steps_msg);
 	free(steps_msg);
+	/* Clean up objects used, as they will be reused. */
+	clear_commit_marks_all(ALL_REV_FLAGS);
 
 	return bisect_checkout(bisect_rev, no_checkout);
 }

Original file line number	Diff line number	Diff line change
`@@ -1082,6 +1082,8 @@ enum bisect_error bisect_next_all(struct repository r, const char prefix)`
`1082`	`1082`	`"Bisecting: %d revisions left to test after this %s\n",`
`1083`	`1083`	`nr), nr, steps_msg);`
`1084`	`1084`	`free(steps_msg);`
	`1085`	`+ /* Clean up objects used, as they will be reused. */`
	`1086`	`+ clear_commit_marks_all(ALL_REV_FLAGS);`
`1085`	`1087`
`1086`	`1088`	`return bisect_checkout(bisect_rev, no_checkout);`
`1087`	`1089`	`}`