completion: zsh: fix file completion regression

felipec · gitster · commit c5dd0c861ab0 · 2020-12-01T10:32:40.000-08:00
Turns out we always need to set the ignored prefix (compset) to have similar behavior as in default Bash. The issue can be seen with: git show master:<tab> Commit 94b2901 wrongly removed it. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh
@@ -116,6 +116,7 @@ __gitcomp_file ()
 {
 	emulate -L zsh
 
+	compset -P '*[=:]'
 	compadd -f -p "${2-}" -- ${(f)1} && _ret=0
 }
 

Original file line number	Diff line number	Diff line change
`@@ -116,6 +116,7 @@ __gitcomp_file ()`
`116`	`116`	`{`
`117`	`117`	`emulate -L zsh`
`118`	`118`
	`119`	`+ compset -P '*[=:]'`
`119`	`120`	`compadd -f -p "${2-}" -- ${(f)1} && _ret=0`
`120`	`121`	`}`
`121`	`122`