packfile: remove unused member from struct pack_entry

bk2204 · gitster · commit c51c39418bb7 · 2018-05-02T13:59:49.000+09:00
The sha1 member in struct pack_entry is unused except for one instance
in which we store a value in it.  Since nobody ever reads this value,
don't bother to compute it and remove the member from struct pack_entry.

Signed-off-by: brian m. carlson &lt;sandals@crustytoothpaste.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/cache.h b/cache.h
@@ -1572,7 +1572,6 @@ struct pack_window {
 
 struct pack_entry {
 	off_t offset;
-	unsigned char sha1[20];
 	struct packed_git *p;
 };
 
diff --git a/packfile.c b/packfile.c
@@ -1833,7 +1833,6 @@ static int fill_pack_entry(const unsigned char *sha1,
 		return 0;
 	e->offset = offset;
 	e->p = p;
-	hashcpy(e->sha1, sha1);
 	return 1;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1833,7 +1833,6 @@ static int fill_pack_entry(const unsigned char *sha1,`
`1833`	`1833`	`return 0;`
`1834`	`1834`	`e->offset = offset;`
`1835`	`1835`	`e->p = p;`
`1836`		`- hashcpy(e->sha1, sha1);`
`1837`	`1836`	`return 1;`
`1838`	`1837`	`}`
`1839`	`1838`