commit.c: rearrange xcalloc arguments

modocache · gitster · commit c4a7b0092bbe · 2014-05-27T14:00:43.000-07:00
xcalloc() takes two arguments: the number of elements and their size.
reduce_heads() passes the arguments in reverse order, passing the
size of a commit*, followed by the number of commit* to be allocated.

Rearrange them so they are in the correct order.

Signed-off-by: Brian Gesiak &lt;modocache@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/commit.c b/commit.c
@@ -1031,7 +1031,7 @@ struct commit_list *reduce_heads(struct commit_list *heads)
 		p->item->object.flags |= STALE;
 		num_head++;
 	}
-	array = xcalloc(sizeof(*array), num_head);
+	array = xcalloc(num_head, sizeof(*array));
 	for (p = heads, i = 0; p; p = p->next) {
 		if (p->item->object.flags & STALE) {
 			array[i++] = p->item;

Original file line number	Diff line number	Diff line change
`@@ -1031,7 +1031,7 @@ struct commit_list reduce_heads(struct commit_list heads)`
`1031`	`1031`	`p->item->object.flags \|= STALE;`
`1032`	`1032`	`num_head++;`
`1033`	`1033`	`}`
`1034`		`- array = xcalloc(sizeof(*array), num_head);`
	`1034`	`+ array = xcalloc(num_head, sizeof(*array));`
`1035`	`1035`	`for (p = heads, i = 0; p; p = p->next) {`
`1036`	`1036`	`if (p->item->object.flags & STALE) {`
`1037`	`1037`	`array[i++] = p->item;`