remote: use xstrdup() instead of strdup()

mhagger · gitster · commit c28cce55e0ea · 2011-10-05T13:45:31.000-07:00
Signed-off-by: Michael Haggerty &lt;mhagger@alum.mit.edu&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/remote.c b/remote.c
@@ -815,7 +815,7 @@ char *apply_refspecs(struct refspec *refspecs, int nr_refspec,
 						    refspec->dst, &ret))
 				return ret;
 		} else if (!strcmp(refspec->src, name))
-			return strdup(refspec->dst);
+			return xstrdup(refspec->dst);
 	}
 	return NULL;
 }
diff --git a/transport-helper.c b/transport-helper.c
@@ -183,7 +183,7 @@ static struct child_process *get_helper(struct transport *transport)
 			ALLOC_GROW(refspecs,
 				   refspec_nr + 1,
 				   refspec_alloc);
-			refspecs[refspec_nr++] = strdup(capname + strlen("refspec "));
+			refspecs[refspec_nr++] = xstrdup(capname + strlen("refspec "));
 		} else if (!strcmp(capname, "connect")) {
 			data->connect = 1;
 		} else if (!prefixcmp(capname, "export-marks ")) {
@@ -445,7 +445,7 @@ static int fetch_with_import(struct transport *transport,
 		if (data->refspecs)
 			private = apply_refspecs(data->refspecs, data->refspec_nr, posn->name);
 		else
-			private = strdup(posn->name);
+			private = xstrdup(posn->name);
 		read_ref(private, posn->old_sha1);
 		free(private);
 	}

Original file line number	Diff line number	Diff line change
`@@ -815,7 +815,7 @@ char apply_refspecs(struct refspec refspecs, int nr_refspec,`
`815`	`815`	`refspec->dst, &ret))`
`816`	`816`	`return ret;`
`817`	`817`	`} else if (!strcmp(refspec->src, name))`
`818`		`- return strdup(refspec->dst);`
	`818`	`+ return xstrdup(refspec->dst);`
`819`	`819`	`}`
`820`	`820`	`return NULL;`
`821`	`821`	`}`