submodule--helper: fix small memory leaks

avar · gitster · commit c270b055d94b · 2021-10-23T10:45:25.000-07:00
Add a missing strbuf_release() and a clear_pathspec() to the
submodule--helper.

Signed-off-by: Ævar Arnfjörð Bjarmason &lt;avarab@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
@@ -3220,6 +3220,7 @@ static void die_on_index_match(const char *path, int force)
 		}
 		free(ps_matched);
 	}
+	clear_pathspec(&ps);
 }
 
 static void die_on_repo_without_commits(const char *path)
@@ -3231,6 +3232,7 @@ static void die_on_repo_without_commits(const char *path)
 		if (resolve_gitlink_ref(path, "HEAD", &oid) < 0)
 			die(_("'%s' does not have a commit checked out"), path);
 	}
+	strbuf_release(&sb);
 }
 
 static int module_add(int argc, const char **argv, const char *prefix)

Original file line number	Diff line number	Diff line change
`@@ -3220,6 +3220,7 @@ static void die_on_index_match(const char *path, int force)`
`3220`	`3220`	`}`
`3221`	`3221`	`free(ps_matched);`
`3222`	`3222`	`}`
	`3223`	`+ clear_pathspec(&ps);`
`3223`	`3224`	`}`
`3224`	`3225`
`3225`	`3226`	`static void die_on_repo_without_commits(const char *path)`
`@@ -3231,6 +3232,7 @@ static void die_on_repo_without_commits(const char *path)`
`3231`	`3232`	`if (resolve_gitlink_ref(path, "HEAD", &oid) < 0)`
`3232`	`3233`	`die(_("'%s' does not have a commit checked out"), path);`
`3233`	`3234`	`}`
	`3235`	`+ strbuf_release(&sb);`
`3234`	`3236`	`}`
`3235`	`3237`
`3236`	`3238`	`static int module_add(int argc, const char *argv, const char prefix)`