Skip to content

Commit bf1ee63

Browse files
smurfixgitster
authored andcommitted
git-svnimport: Use separate arguments in the pipe for git-rev-parse
Some people seem to create SVN branch names with spaces or other shell metacharacters. Signed-off-by: Matthias Urlichs <smurf@smurf.noris.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 7a461b5 commit bf1ee63

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

git-svnimport.perl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -633,7 +633,7 @@ sub commit {
633633

634634
my $rev;
635635
if($revision > $opt_s and defined $parent) {
636-
open(H,"git-rev-parse --verify $parent |");
636+
open(H,'-|',"git-rev-parse","--verify",$parent);
637637
$rev = <H>;
638638
close(H) or do {
639639
print STDERR "$revision: cannot find commit '$parent'!\n";

0 commit comments

Comments
 (0)