diff: reject unknown change class given to --diff-filter

gitster · gitster · commit bf142ec43463 · 2013-07-17T16:24:14.000-07:00
We used to accept "git diff --diff-filter=Q" (note that there is no
such change class 'Q') silently and showed no output (because there
is no such change class 'Q').

Error out when such an input is given.

Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/diff.c b/diff.c
@@ -3537,7 +3537,7 @@ static int parse_diff_filter_opt(const char *optarg, struct diff_options *opt)
 
 		bit = (0 <= optch && optch <= 'Z') ? filter_bit[optch] : 0;
 		if (!bit)
-			continue; /* ignore unknown ones, like we always have */
+			return optarg[i];
 		opt->filter |= bit;
 	}
 	return 0;

Original file line number	Diff line number	Diff line change
`@@ -3537,7 +3537,7 @@ static int parse_diff_filter_opt(const char optarg, struct diff_options opt)`
`3537`	`3537`
`3538`	`3538`	`bit = (0 <= optch && optch <= 'Z') ? filter_bit[optch] : 0;`
`3539`	`3539`	`if (!bit)`
`3540`		`- continue; /* ignore unknown ones, like we always have */`
	`3540`	`+ return optarg[i];`
`3541`	`3541`	`opt->filter \|= bit;`
`3542`	`3542`	`}`
`3543`	`3543`	`return 0;`