Skip to content

Commit be194d5

Browse files
devzero2000gitster
authored andcommitted
lib-gpg.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 03db917 commit be194d5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

t/lib-gpg.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/bin/sh
22

3-
gpg_version=`gpg --version 2>&1`
3+
gpg_version=$(gpg --version 2>&1)
44
if test $? = 127; then
55
say "You do not seem to have gpg installed"
66
else

0 commit comments

Comments
 (0)