receive-pack: plug memory leak in update()

dscho · gitster · commit bda6e82801e3 · 2017-05-08T12:18:20.000+09:00
Reported via Coverity.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
@@ -986,7 +986,8 @@ static const char *update(struct command *cmd, struct shallow_info *si)
 {
 	const char *name = cmd->ref_name;
 	struct strbuf namespaced_name_buf = STRBUF_INIT;
-	const char *namespaced_name, *ret;
+	static char *namespaced_name;
+	const char *ret;
 	struct object_id *old_oid = &cmd->old_oid;
 	struct object_id *new_oid = &cmd->new_oid;
 
@@ -997,6 +998,7 @@ static const char *update(struct command *cmd, struct shallow_info *si)
 	}
 
 	strbuf_addf(&namespaced_name_buf, "%s%s", get_git_namespace(), name);
+	free(namespaced_name);
 	namespaced_name = strbuf_detach(&namespaced_name_buf, NULL);
 
 	if (is_ref_checked_out(namespaced_name)) {

Original file line number	Diff line number	Diff line change
`@@ -986,7 +986,8 @@ static const char update(struct command cmd, struct shallow_info *si)`
`986`	`986`	`{`
`987`	`987`	`const char *name = cmd->ref_name;`
`988`	`988`	`struct strbuf namespaced_name_buf = STRBUF_INIT;`
`989`		`- const char namespaced_name, ret;`
	`989`	`+ static char *namespaced_name;`
	`990`	`+ const char *ret;`
`990`	`991`	`struct object_id *old_oid = &cmd->old_oid;`
`991`	`992`	`struct object_id *new_oid = &cmd->new_oid;`
`992`	`993`
`@@ -997,6 +998,7 @@ static const char update(struct command cmd, struct shallow_info *si)`
`997`	`998`	`}`
`998`	`999`
`999`	`1000`	`strbuf_addf(&namespaced_name_buf, "%s%s", get_git_namespace(), name);`
	`1001`	`+ free(namespaced_name);`
`1000`	`1002`	`namespaced_name = strbuf_detach(&namespaced_name_buf, NULL);`
`1001`	`1003`
`1002`	`1004`	`if (is_ref_checked_out(namespaced_name)) {`