Skip to content

Commit bc0f35c

Browse files
newrengitster
authored andcommitted
t7800 (difftool): add missing &&
Also remove a call to 'git config --unset difftool.prompt', since that is already unset by restore_test_defaults. Acked-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Elijah Newren <newren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent af7b252 commit bc0f35c

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

t/t7800-difftool.sh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ test_expect_success PERL 'difftool --gui works without configured diff.guitool'
9898

9999
# Specify the diff tool using $GIT_DIFF_TOOL
100100
test_expect_success PERL 'GIT_DIFF_TOOL variable' '
101-
git config --unset diff.tool
101+
test_might_fail git config --unset diff.tool &&
102102
GIT_DIFF_TOOL=test-tool &&
103103
export GIT_DIFF_TOOL &&
104104
@@ -166,7 +166,7 @@ test_expect_success PERL 'difftool.prompt config variable is false' '
166166

167167
# Test that we don't have to pass --no-prompt when mergetool.prompt is false
168168
test_expect_success PERL 'difftool merge.prompt = false' '
169-
git config --unset difftool.prompt
169+
test_might_fail git config --unset difftool.prompt &&
170170
git config mergetool.prompt false &&
171171
172172
diff=$(git difftool branch) &&
@@ -211,7 +211,7 @@ test_expect_success PERL 'difftool last flag wins' '
211211
# git-difftool falls back to git-mergetool config variables
212212
# so test that behavior here
213213
test_expect_success PERL 'difftool + mergetool config variables' '
214-
remove_config_vars
214+
remove_config_vars &&
215215
git config merge.tool test-tool &&
216216
git config mergetool.test-tool.cmd "cat \$LOCAL" &&
217217
@@ -254,17 +254,17 @@ test_expect_success PERL 'difftool -x cat' '
254254
'
255255

256256
test_expect_success PERL 'difftool --extcmd echo arg1' '
257-
diff=$(git difftool --no-prompt --extcmd sh\ -c\ \"echo\ \$1\" branch)
257+
diff=$(git difftool --no-prompt --extcmd sh\ -c\ \"echo\ \$1\" branch) &&
258258
test "$diff" = file
259259
'
260260

261261
test_expect_success PERL 'difftool --extcmd cat arg1' '
262-
diff=$(git difftool --no-prompt --extcmd sh\ -c\ \"cat\ \$1\" branch)
262+
diff=$(git difftool --no-prompt --extcmd sh\ -c\ \"cat\ \$1\" branch) &&
263263
test "$diff" = master
264264
'
265265

266266
test_expect_success PERL 'difftool --extcmd cat arg2' '
267-
diff=$(git difftool --no-prompt --extcmd sh\ -c\ \"cat\ \$2\" branch)
267+
diff=$(git difftool --no-prompt --extcmd sh\ -c\ \"cat\ \$2\" branch) &&
268268
test "$diff" = branch
269269
'
270270

0 commit comments

Comments
 (0)