notes: check number of parameters to "git notes copy"

peff · gitster · commit bbb1b8a35a06 · 2010-06-28T09:15:15.000-07:00
Otherwise we may segfault with too few parameters.

Signed-off-by: Jeff King &lt;peff@peff.net&gt;
Tested-by: Bert Wesarg &lt;Bert.Wesarg@googlemail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/notes.c b/builtin/notes.c
@@ -614,6 +614,10 @@ static int copy(int argc, const char **argv, const char *prefix)
 		}
 	}
 
+	if (argc < 2) {
+		error("too few parameters");
+		usage_with_options(git_notes_copy_usage, options);
+	}
 	if (2 < argc) {
 		error("too many parameters");
 		usage_with_options(git_notes_copy_usage, options);
diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
@@ -1044,4 +1044,10 @@ test_expect_success 'GIT_NOTES_REWRITE_REF overrides config' '
 	git log -1 > output &&
 	test_cmp expect output
 '
+
+test_expect_success 'git notes copy diagnoses too many or too few parameters' '
+	test_must_fail git notes copy &&
+	test_must_fail git notes copy one two three
+'
+
 test_done

Original file line number	Diff line number	Diff line change
`@@ -614,6 +614,10 @@ static int copy(int argc, const char *argv, const char prefix)`
`614`	`614`	`}`
`615`	`615`	`}`
`616`	`616`
	`617`	`+ if (argc < 2) {`
	`618`	`+ error("too few parameters");`
	`619`	`+ usage_with_options(git_notes_copy_usage, options);`
	`620`	`+ }`
`617`	`621`	`if (2 < argc) {`
`618`	`622`	`error("too many parameters");`
`619`	`623`	`usage_with_options(git_notes_copy_usage, options);`