help: release strbuf on error return in exec_woman_emacs()

rscharfe · gitster · commit bad0e2c6a89b · 2017-09-07T08:49:27.000+09:00
Signed-off-by: Rene Scharfe &lt;l.s.r@web.de&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/help.c b/builtin/help.c
@@ -131,6 +131,7 @@ static void exec_woman_emacs(const char *path, const char *page)
 		strbuf_addf(&man_page, "(woman \"%s\")", page);
 		execlp(path, "emacsclient", "-e", man_page.buf, (char *)NULL);
 		warning_errno(_("failed to exec '%s'"), path);
+		strbuf_release(&man_page);
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -131,6 +131,7 @@ static void exec_woman_emacs(const char path, const char page)`
`131`	`131`	`strbuf_addf(&man_page, "(woman \"%s\")", page);`
`132`	`132`	`execlp(path, "emacsclient", "-e", man_page.buf, (char *)NULL);`
`133`	`133`	`warning_errno(_("failed to exec '%s'"), path);`
	`134`	`+ strbuf_release(&man_page);`
`134`	`135`	`}`
`135`	`136`	`}`
`136`	`137`