test-date: drop unused parameter to getnanos()

peff · gitster · commit ba285a712d8b · 2019-02-06T12:17:10.000-08:00
The getnanos() helper always gets the current time from our
getnanotime() facility. The caller cannot override it via TEST_DATE_NOW,
and hence we simply ignore the "now" parameter to the function. Let's
remove it, as it may mislead callers into thinking it does something.

Signed-off-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/helper/test-date.c b/t/helper/test-date.c
@@ -83,7 +83,7 @@ static void parse_approx_timestamp(const char **argv, struct timeval *now)
 	}
 }
 
-static void getnanos(const char **argv, struct timeval *now)
+static void getnanos(const char **argv)
 {
 	double seconds = getnanotime() / 1.0e9;
 
@@ -119,7 +119,7 @@ int cmd__date(int argc, const char **argv)
 	else if (!strcmp(*argv, "timestamp"))
 		parse_approx_timestamp(argv+1, &now);
 	else if (!strcmp(*argv, "getnanos"))
-		getnanos(argv+1, &now);
+		getnanos(argv+1);
 	else if (!strcmp(*argv, "is64bit"))
 		return sizeof(timestamp_t) == 8 ? 0 : 1;
 	else if (!strcmp(*argv, "time_t-is64bit"))

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ static void parse_approx_timestamp(const char *argv, struct timeval now)`
`83`	`83`	`}`
`84`	`84`	`}`
`85`	`85`
`86`		`-static void getnanos(const char *argv, struct timeval now)`
	`86`	`+static void getnanos(const char **argv)`
`87`	`87`	`{`
`88`	`88`	`double seconds = getnanotime() / 1.0e9;`
`89`	`89`
`@@ -119,7 +119,7 @@ int cmd__date(int argc, const char **argv)`
`119`	`119`	`else if (!strcmp(*argv, "timestamp"))`
`120`	`120`	`parse_approx_timestamp(argv+1, &now);`
`121`	`121`	`else if (!strcmp(*argv, "getnanos"))`
`122`		`- getnanos(argv+1, &now);`
	`122`	`+ getnanos(argv+1);`
`123`	`123`	`else if (!strcmp(*argv, "is64bit"))`
`124`	`124`	`return sizeof(timestamp_t) == 8 ? 0 : 1;`
`125`	`125`	`else if (!strcmp(*argv, "time_t-is64bit"))`