t/perf/perf-lib.sh: remove test_times.* at the end test_perf_()

jeffhostetler · gitster · commit b9e4d84878b5 · 2021-10-04T22:01:08.000-07:00
Teach test_perf_() to remove the temporary test_times.* files
at the end of each test.

test_perf_() runs a particular GIT_PERF_REPEAT_COUNT times and creates
./test_times.[123...].  It then uses a perl script to find the minimum
over "./test_times.*" (note the wildcard) and writes that time to
"test-results/&lt;testname&gt;.&lt;testnumber&gt;.result".

If the repeat count is changed during the pXXXX test script, stale
test_times.* files (from previous steps) may be included in the min()
computation.  For example:

...
GIT_PERF_REPEAT_COUNT=3 \
test_perf "status" "
	git status
"

GIT_PERF_REPEAT_COUNT=1 \
test_perf "checkout other" "
	git checkout other
"
...

The time reported in the summary for "XXXX.2 checkout other" would
be "min( checkout[1], status[2], status[3] )".

We prevent that error by removing the test_times.* files at the end of
each test.

Signed-off-by: Jeff Hostetler &lt;jeffhost@microsoft.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh
@@ -230,6 +230,7 @@ test_perf_ () {
 		test_ok_ "$1"
 	fi
 	"$TEST_DIRECTORY"/perf/min_time.perl test_time.* >"$base".result
+	rm test_time.*
 }
 
 test_perf () {

Original file line number	Diff line number	Diff line change
`@@ -230,6 +230,7 @@ test_perf_ () {`
`230`	`230`	`test_ok_ "$1"`
`231`	`231`	`fi`
`232`	`232`	`"$TEST_DIRECTORY"/perf/min_time.perl test_time.* >"$base".result`
	`233`	`+ rm test_time.*`
`233`	`234`	`}`
`234`	`235`
`235`	`236`	`test_perf () {`