Merge branch 'jc/maint-1.7.3-checkout-describe'

gitster · gitster · commit b985f2aecaa6 · 2011-06-29T17:03:12.000-07:00
* jc/maint-1.7.3-checkout-describe:
  checkout -b &lt;name&gt;: correctly detect existing branch
diff --git a/builtin/checkout.c b/builtin/checkout.c
@@ -1072,7 +1072,7 @@ int cmd_checkout(int argc, const char **argv, const char *prefix)
 		if (strbuf_check_branch_ref(&buf, opts.new_branch))
 			die(_("git checkout: we do not like '%s' as a branch name."),
 			    opts.new_branch);
-		if (!get_sha1(buf.buf, rev)) {
+		if (ref_exists(buf.buf)) {
 			opts.branch_exists = 1;
 			if (!opts.new_branch_force)
 				die(_("git checkout: branch %s already exists"),
diff --git a/refs.c b/refs.c
@@ -1826,6 +1826,12 @@ int update_ref(const char *action, const char *refname,
 	return 0;
 }
 
+int ref_exists(char *refname)
+{
+	unsigned char sha1[20];
+	return !!resolve_ref(refname, sha1, 1, NULL);
+}
+
 struct ref *find_ref_by_name(const struct ref *list, const char *name)
 {
 	for ( ; list; list = list->next)
diff --git a/refs.h b/refs.h
@@ -54,6 +54,7 @@ extern void warn_dangling_symref(FILE *fp, const char *msg_fmt, const char *refn
  */
 extern void add_extra_ref(const char *refname, const unsigned char *sha1, int flags);
 extern void clear_extra_refs(void);
+extern int ref_exists(char *);
 
 extern int peel_ref(const char *, unsigned char *);
 
diff --git a/t/t2018-checkout-branch.sh b/t/t2018-checkout-branch.sh
@@ -169,4 +169,15 @@ test_expect_success 'checkout -f -B to an existing branch with mergeable changes
 	test_must_fail test_dirty_mergeable
 '
 
+test_expect_success 'checkout -b <describe>' '
+	git tag -f -m "First commit" initial initial &&
+	git checkout -f change1 &&
+	name=$(git describe) &&
+	git checkout -b $name &&
+	git diff --exit-code change1 &&
+	echo "refs/heads/$name" >expect &&
+	git symbolic-ref HEAD >actual &&
+	test_cmp expect actual
+'
+
 test_done

Original file line number	Diff line number	Diff line change
`@@ -1826,6 +1826,12 @@ int update_ref(const char action, const char refname,`
`1826`	`1826`	`return 0;`
`1827`	`1827`	`}`
`1828`	`1828`
	`1829`	`+int ref_exists(char *refname)`
	`1830`	`+{`
	`1831`	`+ unsigned char sha1[20];`
	`1832`	`+ return !!resolve_ref(refname, sha1, 1, NULL);`
	`1833`	`+}`
	`1834`	`+`
`1829`	`1835`	`struct ref find_ref_by_name(const struct ref list, const char *name)`
`1830`	`1836`	`{`
`1831`	`1837`	`for ( ; list; list = list->next)`