[PATCH] Fix git-commit-script to output on stderr when -v fails

Marco Costalba · Junio C Hamano · commit b909a15edef8 · 2005-08-20T10:54:27.000-07:00
When git-commit-script is called with -v option and
verify test fails result is print on stdout
instead of stderr.

[jc: The original patch from Marco updated git-commit-script that
still had the piece of code in question, which has been moved to
an example hook script on its own, so I transplanted the patch to
that new file instead.]

Signed-off-by: Marco Costalba &lt;mcostalba@yahoo.it&gt;
Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
diff --git a/templates/hooks--pre-commit b/templates/hooks--pre-commit
@@ -19,17 +19,17 @@ perl -e '
     sub bad_line {
 	my ($why, $line) = @_;
 	if (!$found_bad) {
-	    print "*\n";
-	    print "* You have some suspicious patch lines:\n";
-	    print "*\n";
+	    print STDERR "*\n";
+	    print STDERR "* You have some suspicious patch lines:\n";
+	    print STDERR "*\n";
 	    $found_bad = 1;
 	}
 	if ($reported_filename ne $filename) {
-	    print "* In $filename\n";
+	    print STDERR "* In $filename\n";
 	    $reported_filename = $filename;
 	}
-	print "* $why (line $lineno)\n";
-	print "$filename:$lineno:$line\n";
+	print STDERR "* $why (line $lineno)\n";
+	print STDERR "$filename:$lineno:$line\n";
     }
     open $fh, "-|", qw(git-diff-cache -p -M --cached HEAD);
     while (<$fh>) {
