t/lib-git-p4: use test_path_is_missing()

Denton-L · gitster · commit b8afb908c261 · 2019-12-20T11:30:44.000-08:00
Previously, cleanup_git() would use `test_must_fail test -d` to ensure
that the directory is removed. However, test_must_fail should only be
used for git commands. Use test_path_is_missing() instead to check that
the directory has been removed.

Signed-off-by: Denton Liu &lt;liu.denton@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/lib-git-p4.sh b/t/lib-git-p4.sh
@@ -175,7 +175,7 @@ stop_and_cleanup_p4d () {
 
 cleanup_git () {
 	retry_until_success rm -r "$git"
-	test_must_fail test -d "$git" &&
+	test_path_is_missing "$git" &&
 	retry_until_success mkdir "$git"
 }
 

Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ stop_and_cleanup_p4d () {`
`175`	`175`
`176`	`176`	`cleanup_git () {`
`177`	`177`	`retry_until_success rm -r "$git"`
`178`		`- test_must_fail test -d "$git" &&`
	`178`	`+ test_path_is_missing "$git" &&`
`179`	`179`	`retry_until_success mkdir "$git"`
`180`	`180`	`}`
`181`	`181`