fetch: Check for a "^{}" suffix with suffixcmp()

Andreas Gruenbacher · gitster · commit aac1d7b88918 · 2010-03-20T09:25:25.000-07:00
Otherwise, we will check random bytes for ref names &lt; 3 characters.

Signed-off-by: Andreas Gruenbacher &lt;agruen@suse.de&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin-fetch.c b/builtin-fetch.c
@@ -588,7 +588,7 @@ static void find_non_local_tags(struct transport *transport,
 		 * to fetch then we can mark the ref entry in the list
 		 * as one to ignore by setting util to NULL.
 		 */
-		if (!strcmp(ref->name + strlen(ref->name) - 3, "^{}")) {
+		if (!suffixcmp(ref->name, "^{}")) {
 			if (item && !has_sha1_file(ref->old_sha1) &&
 			    !will_fetch(head, ref->old_sha1) &&
 			    !has_sha1_file(item->util) &&
