ref-filter: make parse_ref_filter_atom a private function

peff · gitster · commit aa8a5d144da4 · 2017-07-13T12:42:51.000-07:00
The parse_ref_filter_atom() function really shouldn't be
exposed outside of ref-filter.c; its return value is an
integer index into an array that is private in that file.

Since the previous commit removed the sole external caller
(and replaced it with a public function at a more
appropriately level), we can just make this static.

Signed-off-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/ref-filter.c b/ref-filter.c
@@ -364,7 +364,7 @@ struct atom_value {
 /*
  * Used to parse format string and sort specifiers
  */
-int parse_ref_filter_atom(const char *atom, const char *ep)
+static int parse_ref_filter_atom(const char *atom, const char *ep)
 {
 	const char *sp;
 	const char *arg;
diff --git a/ref-filter.h b/ref-filter.h
@@ -104,8 +104,6 @@ struct ref_format {
 int filter_refs(struct ref_array *array, struct ref_filter *filter, unsigned int type);
 /*  Clear all memory allocated to ref_array */
 void ref_array_clear(struct ref_array *array);
-/*  Parse format string and sort specifiers */
-int parse_ref_filter_atom(const char *atom, const char *ep);
 /*  Used to verify if the given format is correct and to parse out the used atoms */
 int verify_ref_format(struct ref_format *format);
 /*  Sort the given ref_array as per the ref_sorting provided */

Original file line number	Diff line number	Diff line change
`@@ -364,7 +364,7 @@ struct atom_value {`
`364`	`364`	`/*`
`365`	`365`	`* Used to parse format string and sort specifiers`
`366`	`366`	`*/`
`367`		`-int parse_ref_filter_atom(const char atom, const char ep)`
	`367`	`+static int parse_ref_filter_atom(const char atom, const char ep)`
`368`	`368`	`{`
`369`	`369`	`const char *sp;`
`370`	`370`	`const char *arg;`